RegexSD: change ddsim interface to use a dictionary instead of a list, fix infinite loop #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresailer
commented
Aug 23, 2024
Test Results 14 files 14 suites 7h 51m 17s ⏱️ For more details on these failures, see this check. Results for commit 6a80e91. ♻️ This comment has been updated with latest results. |
|
There is an issue in the LCG nightly builds, hopefully fixed over the weekend. |
andresailer
commented
Aug 23, 2024
| @@ -632,4 +632,18 @@ if (DD4HEP_USE_GEANT4) | |||
| REGEX_PASS "ResourcesAfterConstruction ConstructSD: VmRSS" | |||
| REGEX_FAIL "Error;ERROR; Exception" | |||
| ) | |||
|
|
|||
| dd4hep_add_test_reg(ClientTests_ddsim_setup_BoxOfStraws | |||
There was a problem hiding this comment.
The test should only run when DDG4 and LCIO are used for building.
Also currently gets no hits. Not sure if shooting in a bad direction, or SD not working.
andresailer
force-pushed
the
DDSIM_regexSDFixes
branch
2 times, most recently
from
6e0f7ea
to
6135977
Compare
Too much hassle to ensure that the list was not duplicating the entries in the list The original implementation also caused infinite loop by appending to the list that was iterated over causing ddsim to use up all the memory and not do anything Added a test with an example ddsim steering file
andresailer
force-pushed
the
DDSIM_regexSDFixes
branch
from
6135977
to
6a80e91
Compare
|
Will merge this, so it shows up in the nightlies, and fix the things that still need fixing in next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too much hassle to ensure that the list was not duplicating the entries in the list
The original implementation also caused infinite loop by appending to the list that was iterated over causing ddsim to use up all the memory and not do anything
Added a test with an example ddsim steering file
@SanghyunKo @lopezzot: please note, but this time actually tested to run
BEGINRELEASENOTES
ENDRELEASENOTES